Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: tzulitai <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2509-flink@git.apache.org>
In-Reply-To: <git-pr-2509-flink@git.apache.org>
Subject: [GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...
Content-Type: text/plain
Message-Id: <20170214145144.3C6F8DFCA3@git1-us-west.apache.org>
Date: Tue, 14 Feb 2017 14:51:44 +0000 (UTC)
archived-at: Tue, 14 Feb 2017 14:51:47 -0000

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2509#discussion_r101051346
  
    --- Diff: flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java ---
    @@ -229,6 +231,8 @@ public void prepare(int numKafkaServers, Properties additionalServerProperties,
     		standardProps.setProperty("zookeeper.connect", zookeeperConnectionString);
     		standardProps.setProperty("bootstrap.servers", brokerConnectionString);
     		standardProps.setProperty("group.id", "flink-tests");
    +		standardProps.setProperty("key.deserializer", "org.apache.kafka.common.serialization.ByteArrayDeserializer");
    +		standardProps.setProperty("value.deserializer", "org.apache.kafka.common.serialization.ByteArrayDeserializer");
    --- End diff --
    
    Somehow, without these settings, the new tests that test `setStartFromXXXX` methods will fail by complaining the property config does not specify settings for the deserializers.
    
    I guess it is because in those tests, we have Kafka clients that are used *only* for offset committing and fetching, in which case the client cannot infer the types to use for the serializers?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---