Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: ex00 <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3205-flink@git.apache.org>
In-Reply-To: <git-pr-3205-flink@git.apache.org>
Subject: [GitHub] flink pull request #3205: [FLINK-5635] Improve Docker tooling to make it eas...
Content-Type: text/plain
Message-Id: <20170209083052.0D37BDFB0E@git1-us-west.apache.org>
Date: Thu,  9 Feb 2017 08:30:52 +0000 (UTC)
archived-at: Thu, 09 Feb 2017 08:30:58 -0000

Github user ex00 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3205#discussion_r100252102
  
    --- Diff: flink-contrib/docker-flink/docker-compose.yml ---
    @@ -16,21 +16,22 @@
     # limitations under the License.
     ################################################################################
     
    -version: "2"
    +# Set the FLINK_DOCKER_IMAGE_NAME environment variable to override the image name to use
    +
    +version: "2.1"
     services:
       jobmanager:
    -    image: flink
    -    container_name: "jobmanager"
    +    image: ${FLINK_DOCKER_IMAGE_NAME:-flink}
         expose:
           - "6123"
    --- End diff --
    
    the variable in yml doesn't depends variable from Dockerfile.
    see https://docs.docker.com/compose/compose-file/#variable-substitution


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---