Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BE7BD200C22 for ; Mon, 6 Feb 2017 14:34:33 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id BB6C2160B53; Mon, 6 Feb 2017 13:34:33 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 124B4160B62 for ; Mon, 6 Feb 2017 14:34:32 +0100 (CET) Received: (qmail 32544 invoked by uid 500); 6 Feb 2017 13:34:32 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 32431 invoked by uid 99); 6 Feb 2017 13:34:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Feb 2017 13:34:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id DBECCC0C68 for ; Mon, 6 Feb 2017 13:34:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id INDVZ_d7-s90 for ; Mon, 6 Feb 2017 13:34:31 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 9B5CF5FE47 for ; Mon, 6 Feb 2017 13:34:28 +0000 (UTC) Received: (qmail 31907 invoked by uid 99); 6 Feb 2017 13:34:27 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Feb 2017 13:34:27 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8492DE04D6; Mon, 6 Feb 2017 13:34:27 +0000 (UTC) From: tillrohrmann To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #2791: [FLINK-4449] [cluster management] add Heartbeat ma... Content-Type: text/plain Message-Id: <20170206133427.8492DE04D6@git1-us-west.apache.org> Date: Mon, 6 Feb 2017 13:34:27 +0000 (UTC) archived-at: Mon, 06 Feb 2017 13:34:33 -0000 Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2791#discussion_r99582457 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java --- @@ -93,8 +92,8 @@ * Sent by the TaskExecutor to notify the ResourceManager that a slot has become available. * * @param resourceManagerLeaderId The ResourceManager leader id - * @param instanceId TaskExecutor's instance id - * @param slotID The SlotID of the freed slot + * @param instanceId TaskExecutor's instance id + * @param slotID The SlotID of the freed slot --- End diff -- Formatting changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---