flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From greghogan <...@git.apache.org>
Subject [GitHub] flink pull request #3402: [FLINK-5890] [gelly] GatherSumApply broken when ob...
Date Thu, 23 Feb 2017 14:30:25 GMT
GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/3402

    [FLINK-5890] [gelly] GatherSumApply broken when object reuse enabled

    GatherSumApplyIteration uses reduce and join for which extra care must be taken when object
reuse is enabled. Adds a check for objects returned by the user to prevent system objects
from being overwritten.
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 5890_gathersumapply_broken_when_object_reuse_enabled

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3402.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3402
    
----
commit c4a7c5103679c70b471e1003c860325d2a919b03
Author: Greg Hogan <code@greghogan.com>
Date:   2017-02-23T13:47:48Z

    [FLINK-5890] [gelly] GatherSumApply broken when object reuse enabled
    
    GatherSumApplyIteration uses reduce and join for which extra care must
    be taken when object reuse is enabled. Adds a check for objects returned
    by the user to prevent system objects from being overwritten.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message