flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5852) Move JSON generation code into static methods
Date Tue, 28 Feb 2017 13:26:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888003#comment-15888003
] 

ASF GitHub Bot commented on FLINK-5852:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3365#discussion_r103434413
  
    --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/utils/JsonTestUtils.java
---
    @@ -0,0 +1,158 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.runtime.webmonitor.utils;
    +
    +import com.fasterxml.jackson.core.JsonFactory;
    +import com.fasterxml.jackson.core.JsonGenerator;
    +import com.fasterxml.jackson.databind.JsonNode;
    +import com.fasterxml.jackson.databind.ObjectMapper;
    +import com.fasterxml.jackson.databind.node.ArrayNode;
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.runtime.accumulators.StringifiedAccumulatorResult;
    +import org.apache.flink.runtime.clusterframework.types.ResourceID;
    +import org.apache.flink.runtime.execution.ExecutionState;
    +import org.apache.flink.runtime.executiongraph.AccessExecution;
    +import org.apache.flink.runtime.executiongraph.AccessExecutionGraph;
    +import org.apache.flink.runtime.executiongraph.AccessExecutionJobVertex;
    +import org.apache.flink.runtime.executiongraph.AccessExecutionVertex;
    +import org.apache.flink.runtime.executiongraph.ArchivedExecution;
    +import org.apache.flink.runtime.executiongraph.ArchivedExecutionGraph;
    +import org.apache.flink.runtime.executiongraph.ArchivedExecutionJobVertex;
    +import org.apache.flink.runtime.executiongraph.ArchivedExecutionVertex;
    +import org.apache.flink.runtime.executiongraph.IOMetrics;
    +import org.apache.flink.runtime.jobgraph.JobStatus;
    +import org.apache.flink.runtime.jobgraph.JobVertexID;
    +import org.apache.flink.runtime.taskmanager.TaskManagerLocation;
    +
    +import java.net.InetAddress;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +import static org.junit.Assert.assertEquals;
    +
    +public class JsonTestUtils {
    +	public static final ObjectMapper mapper = new ObjectMapper();
    +	public static final JsonFactory jacksonFactory = new JsonFactory()
    +		.enable(JsonGenerator.Feature.AUTO_CLOSE_TARGET)
    +		.disable(JsonGenerator.Feature.AUTO_CLOSE_JSON_CONTENT);
    +
    +	private static ArchivedExecutionGraph originalJob;
    +	private static ArchivedExecutionJobVertex originalTask;
    +	private static ArchivedExecutionVertex originalSubtask;
    +	private static ArchivedExecution originalAttempt;
    +
    +	private static final Object lock = new Object();
    +
    +	private JsonTestUtils() {
    +	}
    +
    +	public static AccessExecutionGraph getTestJob() throws Exception {
    +		synchronized (lock) {
    +			if (originalJob == null) {
    +				generateObjects();
    +			}
    +		}
    +		return originalJob;
    +	}
    +
    +	public static AccessExecutionJobVertex getTestTask() throws Exception {
    +		synchronized (lock) {
    +			if (originalJob == null) {
    +				generateObjects();
    +			}
    +		}
    +		return originalTask;
    +	}
    +
    +	public static AccessExecutionVertex getTestSubtask() throws Exception {
    +		synchronized (lock) {
    +			if (originalJob == null) {
    +				generateObjects();
    +			}
    +		}
    +		return originalSubtask;
    +	}
    +
    +	public static AccessExecution getTestAttempt() throws Exception {
    +		synchronized (lock) {
    +			if (originalJob == null) {
    +				generateObjects();
    +			}
    +		}
    +		return originalAttempt;
    +	}
    +
    +	private static void generateObjects() throws Exception {
    --- End diff --
    
    Very generic name that should have a comment.


> Move JSON generation code into static methods
> ---------------------------------------------
>
>                 Key: FLINK-5852
>                 URL: https://issues.apache.org/jira/browse/FLINK-5852
>             Project: Flink
>          Issue Type: Improvement
>          Components: Webfrontend
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.3.0
>
>
> In order to implement the HistoryServer we need a way to generate the JSON responses
independent of the REST API. As such i suggest to move the main parts of the generation code
for job-specific handlers into static methods. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message