flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5767) New aggregate function interface and built-in aggregate functions
Date Thu, 23 Feb 2017 22:31:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881429#comment-15881429
] 

ASF GitHub Bot commented on FLINK-5767:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3354#discussion_r102828543
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SumAggFunction.scala
---
    @@ -44,21 +44,22 @@ abstract class SumAggFunction[T: Numeric] extends AggregateFunction[T]
{
       override def accumulate(accumulator: Accumulator, value: Any) = {
         if (value != null) {
           val v = value.asInstanceOf[T]
    -      val accum = accumulator.asInstanceOf[SumAccumulator[T]]
    -      if (accum.sum == null.asInstanceOf[T]) {
    -        accum.sum = v
    +      val a = accumulator.asInstanceOf[SumAccumulator[T]]
    +      if (!a.f1) {
    --- End diff --
    
    since we start with `sum = 0` we don't need this condition.


> New aggregate function interface and built-in aggregate functions
> -----------------------------------------------------------------
>
>                 Key: FLINK-5767
>                 URL: https://issues.apache.org/jira/browse/FLINK-5767
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
>
> Add a new aggregate function interface. This includes implementing the aggregate interface,
migrating the existing aggregation functions to this interface, and adding the unit tests
for these functions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message