flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5712) update several deprecated configuration options
Date Sat, 11 Feb 2017 04:53:41 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862212#comment-15862212

ASF GitHub Bot commented on FLINK-5712:

Github user barcahead commented on a diff in the pull request:

    --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/services/MesosServicesUtils.java
    @@ -40,9 +41,11 @@ public static MesosServices createMesosServices(Configuration configuration)
     				return new StandaloneMesosServices();
     			case ZOOKEEPER:
    -				final String zkMesosRootPath = configuration.getString(
    +				final String zkMesosRootPath = ConfigurationUtil.getStringWithDeprecatedKeys(
    +					configuration,
    +					ConfigConstants.ZOOKEEPER_MESOS_WORKERS_PATH);
    --- End diff --
    Thanks for the review. 
    I looked into `HighAvailabilityOptions` and found that it doesn't contain all the HA options,
some options are still in `ConfigConstants`. 
    It looks like this part is still in the middle of refactoring, right? I also heard some
discussion from @greghogan about generating configuration document from `ConfigOption` automatically.

    Is there any work I can help with, like move options from `ConfigConstants` to corresponding
`xxConfigOptions` files or the automatic work? If it is the right direction and there is some
work I can do, I would say to have another PR for the work, if not I would just move  `HA_ZOOKEEPER_MESOS_WORKERS_PATH`
to `HighAvailabilityOptions` and finish this PR.

> update several deprecated configuration options 
> ------------------------------------------------
>                 Key: FLINK-5712
>                 URL: https://issues.apache.org/jira/browse/FLINK-5712
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation, Mesos
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Yelei Feng
>            Priority: Minor
>              Labels: configuration, document
>             Fix For: 1.3.0
> 1. We should use 'containerized.heap-cutoff-ratio' and 'containerized.heap-cutoff-min'
instead of deprecated yarn-specific options in configuration doc.
> 2. In mesos mode, we still use deprecated naming convention of zookeeper - 'recovery.zookeeper.path.mesos-workers'.
We should make it consistent with other zookeeper options by using 'high-availability.zookeeper.path.mesos-workers'.

This message was sent by Atlassian JIRA

View raw message