flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5133) Support to set resource for operator in DataStream and DataSet
Date Fri, 24 Feb 2017 14:07:47 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882745#comment-15882745
] 

ASF GitHub Bot commented on FLINK-5133:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3303#discussion_r102945697
  
    --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/DataStream.scala
---
    @@ -144,6 +145,43 @@ class DataStream[T](stream: JavaStream[T]) {
         this
       }
     
    +
    +  /**
    +   * Returns the minimum resource of this operation.
    +   */
    +  def getMinResource: ResourceSpec = stream.getMinResource()
    --- End diff --
    
    To make getters feel more like proper Scala, I would write this as
    ```scala
    def minResource: ResourceSpec = stream.getMinResource()
    ```
    
    The "get" keyword is something that Java encourages, but Scala discourages.


> Support to set resource for operator in DataStream and DataSet
> --------------------------------------------------------------
>
>                 Key: FLINK-5133
>                 URL: https://issues.apache.org/jira/browse/FLINK-5133
>             Project: Flink
>          Issue Type: Sub-task
>          Components: DataSet API, DataStream API
>            Reporter: zhijiang
>            Assignee: zhijiang
>
> This is part of the fine-grained resource configuration.
> For *DataStream*, the *setResource* API will be setted onto *SingleOutputStreamOperator*
similar with other existing properties like parallelism, name, etc.
> For *DataSet*, the *setResource* API will be setted onto *Operator* in the similar way.
> There are two parameters described with minimum *ResourceSpec* and maximum *ResourceSpec*
separately in the API for considering resource resize in future improvements.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message