flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5090) Expose optionally detailed metrics about network queue lengths
Date Mon, 20 Feb 2017 11:05:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874369#comment-15874369
] 

ASF GitHub Bot commented on FLINK-5090:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3348#discussion_r101993135
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionMetrics.java
---
    @@ -0,0 +1,136 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.io.network.partition;
    +
    +import org.apache.flink.metrics.Gauge;
    +import org.apache.flink.metrics.MetricGroup;
    +
    +import static org.apache.flink.util.Preconditions.checkNotNull;
    +
    +public class ResultPartitionMetrics {
    --- End diff --
    
    It would be cool if we could move these into the ```MetricUtils``` class, to consolidate
things a bit. Or move it to ```o.a.f.runtime.metrics.util```.


> Expose optionally detailed metrics about network queue lengths
> --------------------------------------------------------------
>
>                 Key: FLINK-5090
>                 URL: https://issues.apache.org/jira/browse/FLINK-5090
>             Project: Flink
>          Issue Type: New Feature
>          Components: Network
>    Affects Versions: 1.1.3
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>
> For debugging purposes, it is important to have access to more detailed metrics about
the length of network input and output queues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message