flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
Date Wed, 22 Feb 2017 05:11:44 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877486#comment-15877486

ASF GitHub Bot commented on FLINK-4562:

Github user wuchong commented on the issue:

    Hi @shijinkui , sorry for the delay, the change looks very good to me. Regarding to your
    >1. all the example code moved in flink-examples module, as a sub-module. Yes or No?
    Yes, it's fine to me.
    >2. optionally generate runnable example jar in flink distribution. Yes or No?
    I think we can generate the runnable table example jar in the distribution. And I think
we can put it under 
     `/examples/`.  But I find that the gelly example is put into `/opt/`. Maybe we can start
a discussion in mailing list to keep consistent with gelly. 

> table examples make an divided module in flink-examples
> -------------------------------------------------------
>                 Key: FLINK-4562
>                 URL: https://issues.apache.org/jira/browse/FLINK-4562
>             Project: Flink
>          Issue Type: Improvement
>          Components: Examples, Table API & SQL
>            Reporter: shijinkui
>            Assignee: shijinkui
>             Fix For: 1.2.1
> example code should't packaged in table module.

This message was sent by Atlassian JIRA

View raw message