flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4364) Implement TaskManager side of heartbeat from JobManager
Date Mon, 06 Feb 2017 11:28:42 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853861#comment-15853861
] 

ASF GitHub Bot commented on FLINK-4364:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3151#discussion_r99564793
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
    @@ -1058,6 +1092,30 @@ public void handleError(Throwable throwable) {
     		}
     	}
     
    +	/**
    +	 * The heartbeat listener for JobManager and ResourceManager, they can be distinguished
by ResourceID
    +	 * and trigger different processes.
    +	 */
    +	private final class JMRMHeartbeatListener implements HeartbeatListener {
    +
    +		JMRMHeartbeatListener() {
    +		}
    +
    +		@Override
    +		public void notifyHeartbeatTimeout(final ResourceID resourceID) {
    +			log.info("Notify heartbeat timeout for resourceID {}", resourceID);
    --- End diff --
    
    A heartbeat timeout should trigger some kind of action. E.g. unregistering the JM.


> Implement TaskManager side of heartbeat from JobManager
> -------------------------------------------------------
>
>                 Key: FLINK-4364
>                 URL: https://issues.apache.org/jira/browse/FLINK-4364
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Zhijiang Wang
>            Assignee: Zhijiang Wang
>
> The {{JobManager}} initiates heartbeat messages via (JobID, JmLeaderID), and the {{TaskManager}}
will report metrics info for each heartbeat.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message