flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3423: [FLINK-5768] [table] Apply new aggregation functio...
Date Tue, 28 Feb 2017 15:32:02 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3423#discussion_r103475198
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregateReduceGroupFunction.scala
---
    @@ -91,9 +93,13 @@ class DataSetSessionWindowAggregateReduceGroupFunction(
     
         var windowStart: java.lang.Long = null
         var windowEnd: java.lang.Long = null
    -    var currentRowTime:java.lang.Long  = null
    +    var currentRowTime: java.lang.Long = null
     
         val iterator = records.iterator()
    +    val accumulatorList = Array.fill(aggregates.length) {
    --- End diff --
    
    Use a single `JArrayList(2)` for pairwise merging and make it a member variable


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message