flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3423: [FLINK-5768] [table] Apply new aggregation functio...
Date Tue, 28 Feb 2017 15:32:02 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3423#discussion_r103474983
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregateReduceGroupFunction.scala
---
    @@ -104,21 +110,27 @@ class DataSetSessionWindowAggregateReduceGroupFunction(
             // calculate the current window and open a new window
             if (null != windowEnd) {
               // evaluate and emit the current window's result.
    -          doEvaluateAndCollect(out, windowStart, windowEnd)
    +          doEvaluateAndCollect(out, accumulatorList, windowStart, windowEnd)
    +
    +          // clear the accumulator list for all aggregate
    +          for (i <- aggregates.indices) {
    +            accumulatorList(i).clear()
    +          }
             } else {
               // set group keys value to final output.
               groupKeysMapping.foreach {
                 case (after, previous) =>
                   output.setField(after, record.getField(previous))
               }
             }
    -        // initiate intermediate aggregate value.
    -        aggregates.foreach(_.initiate(aggregateBuffer))
    +
             windowStart = record.getField(intermediateRowWindowStartPos).asInstanceOf[Long]
           }
     
    -      // merge intermediate aggregate value to the buffered value.
    -      aggregates.foreach(_.merge(record, aggregateBuffer))
    +      // collect the accumulators for each aggregate
    +      for (i <- aggregates.indices) {
    +        accumulatorList(i).add(record.getField(accumStartPos + i).asInstanceOf[Accumulator])
    --- End diff --
    
    Pairwise merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message