flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sunjincheng121 <...@git.apache.org>
Subject [GitHub] flink pull request #3425: [FLINK-5921] [table] Add custom data types for row...
Date Tue, 28 Feb 2017 06:22:46 GMT
Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3425#discussion_r103384285
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala
---
    @@ -327,6 +329,15 @@ object FunctionGenerator {
             )
           )
     
    +    // generate a constant for time indicator functions.
    +    //   this is a temporary solution and will be removed when FLINK-5884 is implemented.
    +    case ProcTimeExtractor | EventTimeExtractor =>
    +      Some(new CallGenerator {
    +        override def generate(codeGenerator: CodeGenerator, operands: Seq[GeneratedExpression])
= {
    +          GeneratedExpression("0L", "false", "", LONG_TYPE_INFO)
    --- End diff --
    
    Can we change `LONG_TYPE_INFO` to `SqlTimeTypeInfo.TIMESTAMP`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message