flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3417: [FLINK-5907] [java api] [WIP] Fix trailing empty f...
Date Mon, 27 Feb 2017 13:24:10 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3417#discussion_r103197216
  
    --- Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java
---
    @@ -400,7 +400,7 @@ public void readMixedQuotedStringFields() {
     	@Test
     	public void readStringFieldsWithTrailingDelimiters() {
     		try {
    -			final String fileContent = "abc|-def|-ghijk\nabc|-|-hhg\n|-|-|-\n";
    +			final String fileContent = "abc|-def|-ghijk\nabc|-|-hhg\n|-|-|-\n|-|-\nabc|-def\n";
    --- End diff --
    
    This method tests whether an additional field delimiter at the end is accepted.
    Can you move the checks for correctly identifying empty last fields into a separate `testTailingEmptyFields`
method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message