flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #3420: [FLINK-4422] Convert all time interval measurement...
Date Mon, 27 Feb 2017 10:58:43 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3420#discussion_r103181679
  
    --- Diff: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KillerWatchDog.java
---
    @@ -42,12 +42,12 @@
     	@SuppressWarnings("deprecation")
     	@Override
     	public void run() {
    -		final long deadline = System.currentTimeMillis() + timeout;
    +		final long deadline = System.nanoTime() + timeout * 1_000_000L;
     		long now;
     
    -		while (toKill.isAlive() && (now = System.currentTimeMillis()) < deadline)
{
    +		while (toKill.isAlive() && (now = System.nanoTime()) < deadline) {
     			try {
    -				toKill.join(deadline - now);
    +				toKill.join( ( deadline - now ) / 1_000_000L );
    --- End diff --
    
    nit: I don't think we usually have spaces after braces like this here.
    There isn't an agreed codestyle for this, but I think we can remove the spaces to be consistent
with other parts of the code.
    
    Will fix will merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message