flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #3385: [FLINK-5501] JM use running job registry to determ...
Date Fri, 24 Feb 2017 17:44:12 GMT
Github user StephanEwen commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/ZookeeperRegistry.java
    @@ -55,7 +59,7 @@ public void setJobRunning(JobID jobID) throws IOException {
     		try {
     			String zkPath = runningJobPath + jobID.toString();
    -			this.client.setData().forPath(zkPath);
    +			this.client.setData().forPath(zkPath, RUNNING.getBytes());
    --- End diff --
    String to bytes conversion (and bytes to string) must always explicitly specify the encoding
(Charset). Otherwise, there can be mismatches when different machines configure different
default Charsets.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message