flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3166: [FLINK-3849] Add FilterableTableSource interface a...
Date Wed, 22 Feb 2017 16:36:26 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3166#discussion_r102492031
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FilterableTableSource.scala
---
    @@ -0,0 +1,38 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.sources
    +
    +import org.apache.flink.table.expressions.Expression
    +
    +/**
    +  * Adds support for filtering push-down to a [[TableSource]].
    +  * A [[TableSource]] extending this interface is able to filter the fields of the return
table.
    +  *
    +  */
    +trait FilterableTableSource {
    +
    +  /** return an predicate expression that was set. */
    +  def getPredicate: Array[Expression]
    +
    +  /**
    +    * @param predicate a filter expression that will be applied to fields to return.
    --- End diff --
    
    The method docs should be more extensive. We have to explain that the expressions in the
array are conjunctive terms which have to be accepted completely or not at all. All non-accepted
terms have to be returned unmodified.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message