flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #3377: [FLINK-5645] Store accumulators/metrics for cancel...
Date Wed, 22 Feb 2017 14:07:34 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3377#discussion_r102465162
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IOMetrics.java
---
    @@ -53,6 +53,22 @@ public IOMetrics(Meter recordsIn, Meter recordsOut, Meter bytesLocalIn,
Meter by
     		this.numBytesOutPerSecond = bytesOut.getRate();
     	}
     
    +	public IOMetrics(
    +			int numBytesInLocal, int numBytesInRemote, int numBytesOut, int numRecordsIn, int
numRecordsOut,
    +			double numBytesInLocalPerSecond, double numBytesInRemotePerSecond, double numBytesOutPerSecond,
    +			double numRecordsInPerSecond, double numRecordsOutPerSecond) {
    --- End diff --
    
    I'm not sure whether this line breaking pattern is consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message