flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...
Date Tue, 21 Feb 2017 13:50:13 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3348#discussion_r102210056
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
---
    @@ -227,6 +227,14 @@
     	public static final String TASK_MANAGER_NETWORK_NUM_BUFFERS_KEY = "taskmanager.network.numberOfBuffers";
     
     	/**
    +	 * Boolean flag to enable/disable more detailed metrics about inbound/outbound network
queue lengths
    +	 */
    +	@PublicEvolving
    +	public static final ConfigOption<Boolean> NETWORK_DETAILED_METRICS_KEY =
    --- End diff --
    
    I don't think ConfigOptions are supposed to be in this class; itshould be moved to either
```NetworkOptions``` or ```MetricOptions```.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message