flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request #3358: [FLINK-5487] [elasticsearch] At-least-once Elastic...
Date Tue, 21 Feb 2017 11:00:41 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3358#discussion_r102180098
  
    --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
---
    @@ -165,20 +286,36 @@ public void beforeBulk(long executionId, BulkRequest request) {
}
     				@Override
     				public void afterBulk(long executionId, BulkRequest request, BulkResponse response)
{
     					if (response.hasFailures()) {
    -						for (BulkItemResponse itemResp : response.getItems()) {
    -							Throwable failure = callBridge.extractFailureCauseFromBulkItemResponse(itemResp);
    +						BulkItemResponse itemResponse;
    +						Throwable failure;
    +
    +						for (int i = 0; i < response.getItems().length; i++) {
    +							itemResponse = response.getItems()[i];
    +							failure = callBridge.extractFailureCauseFromBulkItemResponse(itemResponse);
     							if (failure != null) {
    -								LOG.error("Failed Elasticsearch item request: {}", failure.getMessage(), failure);
    -								failureThrowable.compareAndSet(null, failure);
    +								LOG.error("Failed Elasticsearch item request: {}", itemResponse.getFailureMessage(),
failure);
    +
    +								if (failureHandler.onFailure(request.requests().get(i), failure, requestIndexer))
{
    --- End diff --
    
    I wonder if it would be better if the `onFailure` method would not return a boolean but
throw a Throwable?
    This way users have more flexibility in implementing their failure handler.
    
    For example if a failure handler is doing three retries and fails afterwards, the original
exception will be thrown. If the `onFailure()` method can throw their own exception, you can
throw a custom exception that tells the user about the three retries.
    
    We can definitively discuss this because this change is annoying to do (docs & javadocs
need to be updated).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message