flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wuchong <...@git.apache.org>
Subject [GitHub] flink pull request #3330: [FLINK-5795][TableAPI&SQL] Improve UDTF to support...
Date Mon, 20 Feb 2017 14:48:20 GMT
Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3330#discussion_r102032869
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/ScalarFunction.scala
---
    @@ -58,6 +60,11 @@ abstract class ScalarFunction extends UserDefinedFunction {
     
       override def toString: String = getClass.getCanonicalName
     
    +  final def functionIdentifier: String = {
    --- End diff --
    
    Can the `functionIdentifier` to be the default implementation of UserDefinedFunction ?
 I think it also works for AggregateFunction in the future. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message