flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #3338: [FLINK-5414] [table] Bump up Calcite version to 1....
Date Mon, 20 Feb 2017 09:43:23 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3338#discussion_r101977305
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/ProjectionTranslator.scala
---
    @@ -108,62 +109,73 @@ object ProjectionTranslator {
           tableEnv: TableEnvironment,
           aggNames: Map[Expression, String],
           propNames: Map[Expression, String]): Seq[NamedExpression] = {
    -    exprs.map(replaceAggregationsAndProperties(_, tableEnv, aggNames, propNames))
    -        .map(UnresolvedAlias)
    -  }
     
    -  private def replaceAggregationsAndProperties(
    +    val projectNames: mutable.HashSet[String] = new mutable.HashSet[String]
    +
    +    def replaceAggregationsAndProperties(
    --- End diff --
    
    Can you rename this or the outer function? Having two functions with the same names is
confusing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message