flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #3295: [FLINK-5747] [distributed coordination] Eager sche...
Date Fri, 17 Feb 2017 12:39:35 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3295#discussion_r101746831
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphUtils.java
---
    @@ -0,0 +1,108 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.executiongraph;
    +
    +import org.apache.flink.runtime.concurrent.BiFunction;
    +import org.apache.flink.runtime.concurrent.Future;
    +import org.apache.flink.runtime.instance.SimpleSlot;
    +import org.apache.flink.util.ExceptionUtils;
    +
    +import java.util.List;
    +
    +/**
    + * Utilities for dealing with the execution graphs and scheduling.
    + */
    +public class ExecutionGraphUtils {
    +
    +	/**
    +	 * Releases the slot represented by the given future. If the future is complete, the
    +	 * slot is immediately released. Otherwise, the slot is released as soon as the future
    +	 * is completed.
    +	 * 
    +	 * <p>Note that releasing the slot means cancelling any task execution currently
    +	 * associated with that slot.
    +	 * 
    +	 * @param slotFuture The future for the slot to release.
    +	 */
    +	public static void releaseSlotFuture(Future<SimpleSlot> slotFuture) {
    +		slotFuture.handle(ReleaseSlotFunction.INSTANCE);
    +	}
    +
    +	/**
    +	 * Releases the all the slots in the list of arrays of {@code ExecutionAndSlot}.
    +	 * For each future in that collection holds: If the future is complete, its slot is
    +	 * immediately released. Otherwise, the slot is released as soon as the future
    +	 * is completed.
    +	 * 
    +	 * <p>This methods never throws any exceptions (subclasses of {@code Exception})
    +	 * and continues to release the remaining slots if one slot release failed. We only
    +	 * catch Exceptions here (and not other throwables) because the code executed while
    +	 * releasing slot does not involve any dynamic 
    --- End diff --
    
    sentence incomplete


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message