flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3166: [FLINK-3849] Add FilterableTableSource interface a...
Date Wed, 15 Feb 2017 22:38:42 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3166#discussion_r101297805
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/BatchTableSourceScan.scala
---
    @@ -59,8 +59,16 @@ class BatchTableSourceScan(
       }
     
       override def explainTerms(pw: RelWriter): RelWriter = {
    +    val s = tableSource match {
    +      case source: FilterableTableSource =>
    +        source.getPredicate.getOrElse("").toString.replaceAll("\\'|\\\"|\\s", "")
    +      case _ => ""
    +    }
         super.explainTerms(pw)
           .item("fields", TableEnvironment.getFieldNames(tableSource).mkString(", "))
    +      // TODO should we have this? If yes how it should look like, as in DataCalc?
    --- End diff --
    
    Yes, the filter should be in the explain string of the table source. 
    I think it would be good if it was formatted as the filter in calc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message