flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haohui <...@git.apache.org>
Subject [GitHub] flink issue #3252: [FLINK-5624] Support tumbling window on streaming tables ...
Date Tue, 14 Feb 2017 21:35:06 GMT
Github user haohui commented on the issue:

    https://github.com/apache/flink/pull/3252
  
    Discussed with @fhueske offline. Thanks a lot for the comments. The V4 PR implements the
following:
    
    * Rebased on top of #3101 
    * `LogicalWindowAggregateRule` implements `RelOptRule` instead of the `ConvertRule`.
    * Instead of adding a new field in `LogicalWindowAggregate`, the implementation now transforms
the original `LogicalAggregate(LogicalProject())` expression to `LogicalProject(LogicalWindowAggregate(LogicalProject(...)))`.
The outermost projection ensures that the operators have the same row types before and after
the transformation.
    
    Please take another look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message