flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...
Date Tue, 14 Feb 2017 14:37:24 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2509#discussion_r101000141
  
    --- Diff: flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
---
    @@ -229,6 +231,8 @@ public void prepare(int numKafkaServers, Properties additionalServerProperties,
     		standardProps.setProperty("zookeeper.connect", zookeeperConnectionString);
     		standardProps.setProperty("bootstrap.servers", brokerConnectionString);
     		standardProps.setProperty("group.id", "flink-tests");
    +		standardProps.setProperty("key.deserializer", "org.apache.kafka.common.serialization.ByteArrayDeserializer");
    +		standardProps.setProperty("value.deserializer", "org.apache.kafka.common.serialization.ByteArrayDeserializer");
    --- End diff --
    
    Why is this needed now? If we have this in the default props, we can not ensure that users
don't need to set it manually


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message