flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3266: [FLINK-5219][TableAPI&SQL] Add non-grouped session...
Date Tue, 14 Feb 2017 11:47:31 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3266#discussion_r101014280
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/dataset/DataSetWindowAggregateITCase.scala
---
    @@ -141,16 +141,18 @@ class DataSetWindowAggregateITCase(configMode: TableConfigMode)
         TestBaseUtils.compareResultAsText(results.asJava, expected)
       }
     
    -  @Test(expected = classOf[UnsupportedOperationException])
    +  @Test
       def testAlldEventTimeSessionGroupWindow(): Unit = {
    -    // Non-grouping Session window on event-time are currently not supported
         val env = ExecutionEnvironment.getExecutionEnvironment
         val tEnv = TableEnvironment.getTableEnvironment(env, config)
         val table = env.fromCollection(data).toTable(tEnv, 'long, 'int, 'string)
         val windowedTable =table
           .window(Session withGap 7.milli on 'long as 'w)
           .groupBy('w)
    -      .select('string.count).toDataSet[Row].collect()
    +      .select('string.count)
    +    val results = windowedTable.toDataSet[Row].collect()
    +    val expected = "6\n1"
    --- End diff --
    
    Would be good to change the query in a way that it checks that multiple sessions are correctly
computed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message