flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3277: [FLINK-5662] [table] Rework internal type handling...
Date Mon, 13 Feb 2017 11:20:07 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
    @@ -428,6 +431,123 @@ abstract class TableEnvironment(val config: TableConfig) {
         (fieldNames.toArray, fieldIndexes.toArray)
    +  /**
    +    * Creates a final converter that maps the internal row type to external type.
    +    *
    +    * @param physicalRowTypeInfo the input of the sink
    +    * @param logicalRowType the logical type with correct field names (esp. for POJO
field mapping)
    +    * @param expectedTypeInfo the outptu type of the sink
    +    * @param functionName name of the map function. Must not be unique but has to be
    +    *                     valid Java class identifier.
    +    */
    +  protected def sinkConversion[T](
    +      physicalRowTypeInfo: TypeInformation[Row],
    +      logicalRowType: RelDataType,
    +      expectedTypeInfo: TypeInformation[T],
    --- End diff --
    Change `expected` to `requested` in the error messages and variable names of this method?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message