flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #3290: [FLINK-5759] [jobmanager] Set UncaughtExceptionHan...
Date Fri, 10 Feb 2017 10:00:02 GMT
Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3290#discussion_r100502133
  
    --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
    @@ -216,11 +220,11 @@ protected int runPrivileged(Configuration config, Configuration
dynamicPropertie
     
     			futureExecutor = Executors.newScheduledThreadPool(
     				numberProcessors,
    -				new NamedThreadFactory("mesos-jobmanager-future-", "-thread-"));
    +				new ExecutorThreadFactory("mesos-jobmanager-future"));
    --- End diff --
    
    Just wondering if 'akkaExecutor' and 'mesos-jobmanager-akka' (or 'coordinationFutureExecutor'
if we want to be more general than 'akka') would carry more information for people not familiar
with the code. As far as I can see, this pool is only used by Akka, whereas the name could
imply that it is somehow used for general futures or even async user code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message