flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From KurtYoung <...@git.apache.org>
Subject [GitHub] flink pull request #3273: [FLINK-5714] [table] Use a builder pattern for cre...
Date Fri, 10 Feb 2017 01:08:39 GMT
Github user KurtYoung commented on a diff in the pull request:

    --- Diff: docs/dev/table_api.md ---
    @@ -253,56 +253,51 @@ Table result = tableEnvironment.ingest("kafka-source");
     The `CsvTableSource` is already included in `flink-table` without additional dependecies.
    -It can be configured with the following properties:
    - - `path` The path to the CSV file, required.
    - - `fieldNames` The names of the table fields, required.
    - - `fieldTypes` The types of the table fields, required.
    - - `fieldDelim` The field delimiter, `","` by default.
    - - `rowDelim` The row delimiter, `"\n"` by default.
    - - `quoteCharacter` An optional quote character for String values, `null` by default.
    - - `ignoreFirstLine` Flag to ignore the first line, `false` by default.
    - - `ignoreComments` An optional prefix to indicate comments, `null` by default.
    - - `lenient` Flag to skip records with parse error instead to fail, `false` by default.
    +It can be created by `CsvTableSource.builder()`, the builder has the following methods
to configure properties:
    + - `path(String path)` Sets the path to the CSV file, required.
    + - `field(String fieldName, TypeInformation<?> fieldType)` Adds a field with the
field name and field type information, required.
    + - `fieldDelimiter(String delim)` Sets the field delimiter, `","` by default.
    + - `lineDelimiter(String delim)` Sets the line delimiter, `"\n"` by default.
    + - `quoteCharacter(Character quote)` Sets the quote character for String values, `null`
by default.
    + - `commentPrefix(String prefix)` Sets a prefix to indicate comments, null by default.
    --- End diff --
    Shall we change to null to `null` to keep consistency

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message