flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wangzhijiang999 <...@git.apache.org>
Subject [GitHub] flink pull request #3151: [FLINK-4364][runtime]mplement TaskManager side of ...
Date Thu, 09 Feb 2017 03:01:23 GMT
Github user wangzhijiang999 commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
    @@ -112,6 +114,13 @@ public TaskManagerRunner(
     		// Initialize the TM metrics
     		TaskExecutorMetricsInitializer.instantiateStatusMetrics(taskManagerMetricGroup, taskManagerServices.getNetworkEnvironment());
    +		HeartbeatManagerImpl heartbeatManager = new HeartbeatManagerImpl(
    +				taskManagerConfiguration.getTimeout().toMilliseconds(),
    +				resourceID,
    +				executor,
    +				Executors.newSingleThreadScheduledExecutor(),
    --- End diff --
    Yes, I totally agree with that and the advantages can avoid bringing extra thread pool
and run all the PRC messages in the uniform executor if **RPCService** can handle well.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message