flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wuchong <...@git.apache.org>
Subject [GitHub] flink pull request #3266: [FLINK-5219][TableAPI&SQL] Add non-grouped session...
Date Wed, 08 Feb 2017 06:48:38 GMT
Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3266#discussion_r99998655
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregateProcessor.scala
---
    @@ -59,7 +61,9 @@ class DataSetSessionWindowAggregateReduceGroupFunction(
         finalRowWindowEndPos: Option[Int],
         gap:Long,
         isInputCombined: Boolean)
    -  extends RichGroupReduceFunction[Row, Row] {
    +  extends AbstractRichFunction
    +    with MapPartitionFunction[Row, Row]
    --- End diff --
    
    I would like to indent `with` and `extends` on the same indent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message