flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wangzhijiang999 <...@git.apache.org>
Subject [GitHub] flink pull request #2770: [FLINK-4354]Implement TaskManager side of heartbea...
Date Tue, 07 Feb 2017 03:09:54 GMT
Github user wangzhijiang999 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2770#discussion_r99737093
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
    @@ -137,6 +140,7 @@ public ResourceManager(
     		this.jobManagerRegistrations = new HashMap<>(4);
     		this.taskExecutors = new HashMap<>(8);
     		this.leaderSessionId = null;
    +		this.resourceID = ResourceID.generate();
    --- End diff --
    
    Yes, in the current implementation it is determined by **ResourceManagerRunner**.This
PR is submitted long time ago and some dependent work is not complete at that time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message