flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From greghogan <...@git.apache.org>
Subject [GitHub] flink issue #3250: Eratosthenes Sieve, a helpful and interesting example of ...
Date Thu, 02 Feb 2017 16:00:10 GMT
Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/3250
  
    The code would need to be cleaned up. I would look to the other examples, add comments,
remove unused code, change anonymous inner classes to be static inner classes, etc. There
is also the question, what makes a good Flink example? Single-threaded programs [1](http://primesieve.org/segmented_sieve.html)
and [2](http://sweet.ua.pt/tos/software/prime_sieve.html) can sieve 10^9 numbers in under
1 second. I think we are better off with batch examples that demonstrate Flink's performance
(such as processing sparse datasets).
    
    If you are interested in adding to the existing examples that would be a good discussion
for the [dev](https://flink.apache.org/community.html#mailing-lists) mailing list. I also
expect that more users are reading the online documentation than inspecting the examples so
that is another opportunity for contributions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message