Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: zentol <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
Message-ID: <git-pr-3103-flink@git.apache.org>
Subject: [GitHub] flink pull request #3103: [FLINK-5464] [metrics] Prevent some NPEs
Content-Type: text/plain
Date: Thu, 12 Jan 2017 11:51:30 +0000 (UTC)
archived-at: Thu, 12 Jan 2017 11:51:39 -0000

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/3103

    [FLINK-5464] [metrics] Prevent some NPEs

    This PR prevents some NullPointerExceptions from occurring in the metric system.
    
    - When registering a metric that is null the metric is ignored, and a warning is logged.
      - i.e ```group.counter("counter", null);```
    - The MetricDumpSerialization completely ignores gauges if their value is null.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 5464_mqs_npe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3103
    
----
commit 0912848b3ce54842fc6810aa0b041db5547ac690
Author: zentol <chesnay@apache.org>
Date:   2017-01-12T11:41:56Z

    [FLINK-5464] [metrics] Ignore metrics that are null

commit 941c83a599221fc57c02605e2c3bc348d70aa8b2
Author: zentol <chesnay@apache.org>
Date:   2017-01-12T11:42:26Z

    [FLINK-5464] [metrics] Prevent Gauge NPE in serialization

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---