Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AB3BC200C16 for ; Wed, 25 Jan 2017 16:41:34 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A9FB4160B4E; Wed, 25 Jan 2017 15:41:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0082B160B50 for ; Wed, 25 Jan 2017 16:41:33 +0100 (CET) Received: (qmail 62739 invoked by uid 500); 25 Jan 2017 15:41:33 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 62730 invoked by uid 99); 25 Jan 2017 15:41:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jan 2017 15:41:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B7B84C2B3B for ; Wed, 25 Jan 2017 15:41:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Ymj_5aShlBP7 for ; Wed, 25 Jan 2017 15:41:32 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 99F425F613 for ; Wed, 25 Jan 2017 15:41:31 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7A6F5E0146 for ; Wed, 25 Jan 2017 15:41:28 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2CD3D252A2 for ; Wed, 25 Jan 2017 15:41:27 +0000 (UTC) Date: Wed, 25 Jan 2017 15:41:27 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-5628) CheckpointStatsTracker implements Serializable but isn't MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 25 Jan 2017 15:41:34 -0000 [ https://issues.apache.org/jira/browse/FLINK-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837928#comment-15837928 ] ASF GitHub Bot commented on FLINK-5628: --------------------------------------- Github user zentol commented on the issue: https://github.com/apache/flink/pull/3215 add `SubtaskStateStats` to the list. > CheckpointStatsTracker implements Serializable but isn't > -------------------------------------------------------- > > Key: FLINK-5628 > URL: https://issues.apache.org/jira/browse/FLINK-5628 > Project: Flink > Issue Type: Bug > Components: Local Runtime > Affects Versions: 1.2.0, 1.3.0 > Reporter: Chesnay Schepler > Assignee: Ufuk Celebi > Priority: Blocker > Fix For: 1.3.0 > > > The CheckpointStatsTracker implements the Serializable interface, even though it no longer is serializable as it contains a List. > This was introduced in 579bc96446d598a2cfe8237b4ebd62d8c9df3483 which reworked the checkpoint stats tracking, > This does not affect 1.2 or 1.3 in any way (since these objects aren't serialized there), but it blocks the implementation of the HistoryServer. > The AccessExecution*/ArchivedExecution* classes, which are supposed to be a serializable form of the ExecutionGraph, are thus broken as they also make use of the CheckpointStatsTracker. > (Note: * = Graph/ExecutionJobVertex/ExecutionVertex/Execution) . > This wasn't catched in tests since no ExecutionJobVertices were given to the CheckpointStatsTracker in ArchivedExecutionGraphTest#setExecutionGraph. -- This message was sent by Atlassian JIRA (v6.3.4#6332)