Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Wed, 18 Jan 2017 14:57:26 +0000 (UTC)
From: "Fabian Hueske (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13035822.1484731048000.41552.1484751446801@Atlassian.JIRA>
In-Reply-To: <JIRA.13035822.1484731048000@Atlassian.JIRA>
References: <JIRA.13035822.1484731048000@Atlassian.JIRA> <JIRA.13035822.1484731048524@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-5548) Move checks for DataStreamRel
 validity into constructor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 18 Jan 2017 14:57:45 -0000


    [ https://issues.apache.org/jira/browse/FLINK-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828221#comment-15828221 ] 

Fabian Hueske commented on FLINK-5548:
--------------------------------------

Thanks for checking [~jark], I had assumed that some {{DataStreamRel}}s do also have checks in {{translateToPlan()}}. 
Closing this issue as invalid then.

Thanks, Fabian

> Move checks for DataStreamRel validity into constructor
> -------------------------------------------------------
>
>                 Key: FLINK-5548
>                 URL: https://issues.apache.org/jira/browse/FLINK-5548
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Fabian Hueske
>            Priority: Minor
>
> At the moment, most check to verify that a {{DataStreamRel}} is valid are done in the {{translateToPlan()}} method. These checks are for instance validating that a {{DataStreamJoin}} has at least one equality predicate.
> Usually, the optimization process (i.e., the translation rules) should take care that no plans with invalid operators can be constructed. However, we should have these validity checks as an additional safety net which catch invalid plans if optimization rules are added or modified.
> These checks should be done in the constructor to ensure that invalid operators are identified and not overlooked because this plan alternative was more expensive than a valid one. 
> This issue is to check all {{DataStreamRel}} nodes and move their validity checks into the constructor.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)