Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F3CC9200BFB for ; Wed, 11 Jan 2017 11:58:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id F2A4E160B52; Wed, 11 Jan 2017 10:58:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 74ACA160B4E for ; Wed, 11 Jan 2017 11:58:59 +0100 (CET) Received: (qmail 24004 invoked by uid 500); 11 Jan 2017 10:58:58 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 23965 invoked by uid 99); 11 Jan 2017 10:58:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Jan 2017 10:58:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7569C2C03E3 for ; Wed, 11 Jan 2017 10:58:58 +0000 (UTC) Date: Wed, 11 Jan 2017 10:58:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-5442) Add test to fix ordinals of serialized enum StateDescriptor.Type MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 11 Jan 2017 10:59:00 -0000 [ https://issues.apache.org/jira/browse/FLINK-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817992#comment-15817992 ] ASF GitHub Bot commented on FLINK-5442: --------------------------------------- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3091 If it is in so shortly, lets make it clean and keep the new order... > Add test to fix ordinals of serialized enum StateDescriptor.Type > ---------------------------------------------------------------- > > Key: FLINK-5442 > URL: https://issues.apache.org/jira/browse/FLINK-5442 > Project: Flink > Issue Type: Improvement > Components: State Backends, Checkpointing > Reporter: Stefan Richter > Assignee: Stefan Richter > Priority: Minor > > The order in which elements are contained in the enum {{StateDescriptor.Type}} is important because the ordinal is used for custom de/serialization. Changing this order would break the serialization format. We should add a test that enforces the current order. -- This message was sent by Atlassian JIRA (v6.3.4#6332)