Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Thu, 19 Jan 2017 09:59:27 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13007847.1474965817000.50629.1484819967179@Atlassian.JIRA>
In-Reply-To: <JIRA.13007847.1474965817000@Atlassian.JIRA>
References: <JIRA.13007847.1474965817000@Atlassian.JIRA> <JIRA.13007847.1474965817808@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-4693) Add session group-windows for batch
 tables
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 19 Jan 2017 09:59:32 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829628#comment-15829628 ] 

ASF GitHub Bot commented on FLINK-4693:
---------------------------------------

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3150#discussion_r96825508
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala ---
    @@ -226,27 +225,101 @@ object AggregateUtil {
               aggregates,
               groupingOffsetMapping,
               aggOffsetMapping,
    -          intermediateRowArity,
    +          intermediateRowArity + 1,// the addition one field is used to store time attribute
               outputType.getFieldCount)
    +
    +      case EventTimeSessionGroupWindow(_, _, gap) =>
    +        val (startPos, endPos) = if (isTimeWindow(window)) {
    --- End diff --
    
    Good catching!! 


> Add session group-windows for batch tables	
> -------------------------------------------
>
>                 Key: FLINK-4693
>                 URL: https://issues.apache.org/jira/browse/FLINK-4693
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: sunjincheng
>
> Add Session group-windows for batch tables as described in [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations]. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)