Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3046-flink@git.apache.org>
In-Reply-To: <git-pr-3046-flink@git.apache.org>
Subject: [GitHub] flink pull request #3046: [FLINK-5386][Table API & SQL] refactoring Window C...
Content-Type: text/plain
Message-Id: <20170119141050.F0D98DFDF1@git1-us-west.apache.org>
Date: Thu, 19 Jan 2017 14:10:50 +0000 (UTC)
archived-at: Thu, 19 Jan 2017 14:10:56 -0000

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3046#discussion_r96862582
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/windows.scala ---
    @@ -60,7 +60,7 @@ abstract class EventTimeWindow(val timeField: Expression) extends GroupWindow {
         * @return this window
         */
       def as(alias: Expression): EventTimeWindow = {
    --- End diff --
    
    I think the `as` methods of windows can could be moved to `Window`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---