Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: StephanEwen <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3143-flink@git.apache.org>
In-Reply-To: <git-pr-3143-flink@git.apache.org>
Subject: [GitHub] flink pull request #3143: [FLINK-5530] fix race condition in AbstractRocksDB...
Content-Type: text/plain
Message-Id: <20170118112535.D1E5CDFADF@git1-us-west.apache.org>
Date: Wed, 18 Jan 2017 11:25:35 +0000 (UTC)
archived-at: Wed, 18 Jan 2017 11:25:40 -0000

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3143#discussion_r96612773
  
    --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBState.java ---
    @@ -132,55 +132,95 @@ public void setCurrentNamespace(N namespace) {
     				namespaceSerializer);
     
     		int keyGroup = KeyGroupRangeAssignment.assignToKeyGroup(des.f0, backend.getNumberOfKeyGroups());
    -		writeKeyWithGroupAndNamespace(keyGroup, des.f0, des.f1);
    -		return backend.db.get(columnFamily, keySerializationStream.toByteArray());
    +
    +		// we cannot reuse the keySerializationStream member since this method
    +		// is called concurrently to the other ones and it may thus contain garbage
    +		ByteArrayOutputStreamWithPos tmpKeySerializationStream =
    --- End diff --
    
    You don't need to wrap that heavily, most code uses 120 characters line lengths.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---