Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: aljoscha <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2948-flink@git.apache.org>
In-Reply-To: <git-pr-2948-flink@git.apache.org>
Subject: [GitHub] flink pull request #2948: [FLINK-5265] Introduce state handle replication mo...
Content-Type: text/plain
Message-Id: <20170113112718.327CADFADF@git1-us-west.apache.org>
Date: Fri, 13 Jan 2017 11:27:18 +0000 (UTC)
archived-at: Fri, 13 Jan 2017 11:27:21 -0000

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2948#discussion_r95979296
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorStateCheckpointOutputStream.java ---
    @@ -66,8 +66,10 @@ OperatorStateHandle closeAndGetHandle() throws IOException {
     			startNewPartition();
     		}
     
    -		Map<String, long[]> offsetsMap = new HashMap<>(1);
    -		offsetsMap.put(DefaultOperatorStateBackend.DEFAULT_OPERATOR_STATE_NAME, partitionOffsets.toArray());
    +		Map<String, OperatorStateHandle.StateMetaInfo> offsetsMap = new HashMap<>(1);
    +		OperatorStateHandle.StateMetaInfo metaInfo =
    +				new OperatorStateHandle.StateMetaInfo(partitionOffsets.toArray(), OperatorStateHandle.Mode.BROADCAST);
    --- End diff --
    
    I think this should be `SPLIT_REDISTRIBUTE` to conform to the old behaviour.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---