flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wuchong <...@git.apache.org>
Subject [GitHub] flink pull request #3233: [FLINK-5678] [table] Fix User-defined Functions do...
Date Sun, 29 Jan 2017 12:40:43 GMT
GitHub user wuchong opened a pull request:

    https://github.com/apache/flink/pull/3233

    [FLINK-5678] [table] Fix User-defined Functions do not support all types of parameters

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    The bug of [FLINK-5678] (doesn't support Long and temporal types) is not only happen in
TableFunctions but also ScalarFunctions. I fixed them and added some tests. @twalthr Could
you have a look to make sure that I didn't miss anything ? 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wuchong/flink udf-type-fix-FLINK-5678

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3233.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3233
    
----
commit 2b72a3b42137a3f06a23167de2aee10f7f5191ec
Author: Jark Wu <wuchong.wc@alibaba-inc.com>
Date:   2017-01-29T12:36:28Z

    [FLINK-5678] [table] Fix User-defined Functions do not support all types of parameters

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message