flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #3228: [FLINK-5663] Prevent leaking SafetyNetCloseableReg...
Date Fri, 27 Jan 2017 17:04:00 GMT
GitHub user StefanRRichter opened a pull request:

    https://github.com/apache/flink/pull/3228

    [FLINK-5663] Prevent leaking SafetyNetCloseableRegistry though InheritableThreadLocal

    This PR prevents the `SafetyNetCloseableRegistry` from leaking into pooled threads through
`InheritableThreadLocal`. 
    
    As first step, we use `ThreadLocal` instead of `InheritableThreadLocal` to hold the closeable
registries.
    
    Additionally, we also create safety nets for the file system at the scope of the checkpointing
thread. We hope that this covers already covers most cases. Other threads could actually also
create safety nets for their scope right now.
    
    As a last change, we made the reaper thread a singleton, because we could potentially
create more registries now and it is not required to have one reaper thread per registry.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StefanRRichter/flink safetyNet2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3228
    
----
commit 21e2a31ece3c56a9d79cb127f9829f770ebe56cf
Author: Stefan Richter <s.richter@data-artisans.com>
Date:   2017-01-27T15:32:35Z

    [FLINK-5663] Prevent leaking safetynet closeable registry

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message