flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5427) Typo in the event_timestamps_watermarks doc
Date Wed, 11 Jan 2017 11:08:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818016#comment-15818016
] 

ASF GitHub Bot commented on FLINK-5427:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3082
  
    Thanks for noticing and fixing this!
    Merging...


> Typo in the event_timestamps_watermarks doc
> -------------------------------------------
>
>                 Key: FLINK-5427
>                 URL: https://issues.apache.org/jira/browse/FLINK-5427
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.2.0
>            Reporter: Yelei Feng
>            Priority: Minor
>              Labels: documentation
>             Fix For: 1.2.0
>
>
> I was reading the watermark doc: https://ci.apache.org/projects/flink/flink-docs-release-1.2/dev/event_timestamps_watermarks.html
> We should replace element with lastElement in the body of method checkAndGetNextWatermark:
> {code:java}
> public Watermark checkAndGetNextWatermark(MyEvent lastElement, long extractedTimestamp)
{
> 		return element.hasWatermarkMarker() ? new Watermark(extractedTimestamp) : null;
> 	}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message