flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5256) Extend DataSetSingleRowJoin to support Left and Right joins
Date Wed, 18 Jan 2017 07:48:27 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827558#comment-15827558
] 

ASF GitHub Bot commented on FLINK-5256:
---------------------------------------

Github user ex00 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3033#discussion_r96580679
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
    @@ -46,6 +47,7 @@ class DataSetSingleRowJoin(
         rowRelDataType: RelDataType,
         joinCondition: RexNode,
         joinRowType: RelDataType,
    +    joinType: JoinRelType,
    --- End diff --
    
    Will do throw exception if joinType is JoinRelType.FULL ?


> Extend DataSetSingleRowJoin to support Left and Right joins
> -----------------------------------------------------------
>
>                 Key: FLINK-5256
>                 URL: https://issues.apache.org/jira/browse/FLINK-5256
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Anton Mushin
>
> The {{DataSetSingleRowJoin}} is a broadcast-map join that supports arbitrary inner joins
where one input is a single row.
> I found that Calcite translates certain subqueries into non-equi left and right joins
with single input. These cases can be handled if the  {{DataSetSingleRowJoin}} is extended
to support outer joins on the non-single-row input, i.e., left joins if the right side is
single input and vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message