flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #3206: [FLINK-5612] Fix GlobPathFilter not-serializable e...
Date Thu, 26 Jan 2017 16:28:56 GMT
Github user StephanEwen commented on a diff in the pull request:

    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java
    @@ -52,8 +53,13 @@
     	private static final long serialVersionUID = 1L;
    -	private final ArrayList<PathMatcher> includeMatchers;
    -	private final ArrayList<PathMatcher> excludeMatchers;
    +	private final List<String> includePatterns;
    +	private final List<String> excludePatterns;
    +	// Path matchers are not serializable so we are delaying their
    +	// creation until they are used
    +	transient private ArrayList<PathMatcher> includeMatchers;
    --- End diff --
    Agreed, let's get the style aligned with the rest of the project.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message