flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...
Date Wed, 25 Jan 2017 14:27:51 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2836#discussion_r97788511
  
    --- Diff: flink-contrib/flink-storm-examples/pom.xml ---
    @@ -364,6 +363,18 @@ under the License.
     							</transformers>
     						</configuration>
     					</execution>
    +					<execution>
    +						<id>shade-flink</id>
    --- End diff --
    
    With this we execute the shade-plugin also for other build-profiles, correct? (same for
`flink-examples/flink-examples-streaming`) It would be cool if this would only be done when
creating the coverage report, so that the normal build-time is unaffected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message