flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #3198: [FLINK-5626] Improved resource deallocation in Roc...
Date Tue, 24 Jan 2017 13:01:38 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3198#discussion_r97540391
  
    --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
    @@ -245,14 +235,15 @@ public int getKeyGroupPrefixBytes() {
     		// hold the db lock while operation on the db to guard us against async db disposal
     		synchronized (asyncSnapshotLock) {
     
    -			if (kvStateInformation.isEmpty()) {
    -				LOG.info("Asynchronous RocksDB snapshot performed on empty keyed state at " + timestamp
+
    -						" . Returning null.");
    +			if (db != null) {
     
    -				return new DoneFuture<>(null);
    -			}
    +				if (kvStateInformation.isEmpty()) {
    +					LOG.info("Asynchronous RocksDB snapshot performed on empty keyed state at " + timestamp
+
    --- End diff --
    
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message